Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix REST API for popstore.ProductServices.get#SortedProductList #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

acetousk
Copy link
Member

@jonesde
Copy link
Member

jonesde commented Jan 13, 2022

What is the scenario this is meant to accommodate? Doing a query on ProductCategoryMemberProduct with no productCategoryId would in effect find all products that are in any category. It might be best if this treated the no category scenario the same as no products in the category (ie if a category is not specified then no products found).

On a side note, the same effect as this patch can be done with the ignore-if-empty="true" attribute on the econdition element, but either way I don't think this is the business logic we want here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants