Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Second Factor Authentication to Moqui #123

Closed
wants to merge 105 commits into from

Conversation

acetousk
Copy link
Member

The pull request makes changes to moqui-framework, moqui-runtime, and SimpleScreens.

The biggest things to check are:

  • In my development environment, I was occasionally getting 28 second loading screens when calling services in UserServices.xml to create a UserAuthcFactor. Make sure that in other environments this doesn't happen.
  • Ensure that the forms don't allow the user to specify their userId so that permissions for users are enforced.

In SimpleScreens:

  • Add a authentication configuration method to Account.xml including features:
    • Add any type of authentication method for any user
    • Verify authentication types like authenticator app (totp) and email (NOTE: It currently does not matter if a user's authentication type is verified before it is used. In the future this probably will become necessary)
    • Invalidate any type of authentication method for any user

acetousk and others added 30 commits March 10, 2021 20:30
…e UserAccountDetail.xml and Account.xml screens and subscreens
…the buttons "Add Single Use Code" and "Add Email Factor"
…FacilityLocation if a locationSeqId is specified so it does not default to the first found by facilityId only, should be no location if no locationSeqId specified
… extends form in PhysicalQuantity) use new strictAll parameter in record#PhysicalInventoryQuantity and record#PhysicalInventoryChange services to get strict behavior that behaves more as expected in the UI with all distinguishing fields visible
…ith Picklist type WorkEfforts, similar to equipment filter and display already there
…ind, are already handle in WHERE clause SQL in generated excludeOnPicklistCond
… transition to see matching records after physical diff
…abled if user does not have authz or System app is not deployed
…o, refine default layout, and add QuickMove subscreen for a per-row quick Move dialog
Add persistent display of Store above screen tabs.
Add persistent display of Product above screen tabs.
Add persistent display of Asset above screen tabs.
Simplify changes to use templates where possible.
Simplify changes to use templates where possible.
Simplify changes to use templates where possible.
Correct last change
Signed to permit completion of code changes.
…d name conflict from recent changes to wrapping Facility.xml screen (in PopCommerce so far)
…ng screens in PopCommerce, small improvement to Search screen for Any default select
jonesde and others added 28 commits June 30, 2021 23:03
… toolbar to produce and pack available assemblies in case something goes awry with the automation
…acked dialog on ShipmentDetail and ShipmentItems and the Pack Completed dialog on PackSummary/PackCompleted; change PackSummary and ShipmentDetail to use assembly WE info from updated get#ShipmentDisplayInfo service
… dropdown when creating a new invoice, use allow-empty instead of a no value New option which ends up having a value
…uping drop-down to Project Client Invoice form, default to invoice item per worker, still supports old per entry, may have more variations over time
…products in the reservations only in pick locations filter with BOM quantity multiplier
…ents Term, and to Order Part edit form and display fields
…om records, and add uom type description prefix
…e UserAccountDetail.xml and Account.xml screens and subscreens
…, GL TX should be posted before going into Write Off status (ie has been Finalized and Payment Received in the form of a write off credit memo invoice); on InvoiceReconciliation report add InvoiceWriteOff status to be included so those invoices don't show a false discrepancy
…picked and change Not Issued qty to Issed (quantity - quantityNotIssued)
…ress dropdown (moqui#117)

* Add first version of lead screens and also salesfunnel.

* Revert "Add first version of lead screens and also salesfunnel."

This reverts commit bfbdc2e.

* Add "Quick Ship Entire Order" button on OrderDetails screen

* Fixed a NPE

* Revert "Add "Quick Ship Entire Order" button on OrderDetails screen"

This reverts commit 993c47a.

* The productId is required in header find dialog.

* Use PostalShippingOrigin instead of PostalShippingDest for Origin Address dropdown list condition

* Fixed a typo

* Fixed Ambiguous method overloading for method java.math.BigDecimal#multiply

* Use 0.0 instead of 0 because Groovy interprets 0.0 as a BigDecimal
Use the Destination address for returns from customers and Original address for purchase order from suppliers

Co-authored-by: Wei Zhang <zhangw@shinetechchina.com>
Co-authored-by: Supatthra Nawicha <tukkata@antwebsystems.com>
Fixed Ambiguous method overloading for method java.math.BigDecimal#multiply
Use the Destination address for returns from customers and Original address for purchase order from suppliers to populate Origin Address dropdown
…the buttons "Add Single Use Code" and "Add Email Factor"
Fixed Ambiguous method overloading for method java.math.BigDecimal#multiply
Use the Destination address for returns from customers and Original address for purchase order from suppliers to populate Origin Address dropdown
…e UserAccountDetail.xml and Account.xml screens and subscreens
…the buttons "Add Single Use Code" and "Add Email Factor"
@acetousk
Copy link
Member Author

acetousk commented Jul 2, 2021

Because of a lack of planning on my part with git commits on several occasions, I have created a separate, identical pull request: #124.

Closing this PR due to redundant code changes.

@acetousk acetousk closed this Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants