Image no mailpieces700 fix #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
moralmunky
commented
Feb 23, 2020
moralmunky
commented
- Removed the code to check for and copy mail_none.gif and image-no-mailpieces700.jpg to the image path.
- Changed code to add the image-no-mailpieces700.jpg to the array from the custom_component folder
- Changed code to create the no mail gif to copy mail_none.gif from the custom component folder
- Updated the ImagesDelete to be a copy of the image list at that point in time instead of a reference to the images array
When copying no_mail.gif to the www path it references the file stored in the component file negating the need to keep a copy in the ww path
Remove code copying no_mail.gif and image-no-mailpieces700.jpg. Updated path for the image-no-mailpieces700.jpg when it is added to the image array if needed.
ImagesDelete was previously a reference to the images array instead of a copy of it at a certain point in time.
firstof9
approved these changes
Feb 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.