Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

Settings don't like extra spaces #152

Closed
moranje opened this issue Feb 13, 2020 · 1 comment
Closed

Settings don't like extra spaces #152

moranje opened this issue Feb 13, 2020 · 1 comment

Comments

@moranje
Copy link
Owner

moranje commented Feb 13, 2020

Description

The workflow fails when two consecutive spaces are added after the todo:setting keyword

Steps to reproduce behavior

Query: todo setting <-- two spaces

Expected behavior

The workflow shouldn't crash.

Error logs

ALFRED WORKFLOW TODOIST

title: TypeError
description: Use delete() to clear values

os: macOS 10.15.3
query:
node.js: v13.8.0
alfred: 3.8.6
workflow: 6.0.0-alpha.5
workflow-id: user.workflow.A389586F-E60F-4C60-BDCA-746D1CAEB82D

Stack: TypeError: Use delete() to clear values
at Conf.set (~/Sync/Projects/alfred-workflow-todoist/dist/workflow/alfred-workflow-todoist.js:11736:19)
at getValue (~/Sync/Projects/alfred-workflow-todoist/dist/workflow/alfred-workflow-todoist.js:28064:42)
at readSettings (~/Sync/Projects/alfred-workflow-todoist/dist/workflow/alfred-workflow-todoist.js:28085:16)
at command (~/Sync/Projects/alfred-workflow-todoist/dist/workflow/alfred-workflow-todoist.js:28388:16)
at main$2 (~/Sync/Projects/alfred-workflow-todoist/dist/workflow/alfred-workflow-todoist.js:30883:12)
at Object. (~/Sync/Projects/alfred-workflow-todoist/dist/workflow/alfred-workflow-todoist.js:30889:5)

moranje added a commit that referenced this issue Feb 13, 2020
moranje pushed a commit that referenced this issue Feb 13, 2020
# [6.0.0-alpha.6](v6.0.0-alpha.5...v6.0.0-alpha.6) (2020-02-13)

### Bug Fixes

* **commands:** error when trying to retrieve a non existent project ([42e0009](42e0009))
* **settings:** [#152](#152) settings break with multiple consecutive spaces ([b3f2f2a](b3f2f2a))
@moranje
Copy link
Owner Author

moranje commented Feb 13, 2020

🎉 This issue has been resolved in version 6.0.0-alpha.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@moranje moranje closed this as completed Feb 13, 2020
github-actions bot pushed a commit that referenced this issue Feb 26, 2020
# [6.0.0-beta.1](v5.8.4...v6.0.0-beta.1) (2020-02-26)

### Bug Fixes

* **settings:** rename annonymous_statistics to error_tracking ([3816345](3816345))
* api filter requests being broken ([3b344a1](3b344a1))
* **build:** possibly fix version number not updated in alfred workflow ([ac02c22](ac02c22))
* **cache:** cache always being reset ([d83408e](d83408e))
* **cache:** handle empty resource lists ([af89785](af89785))
* **cache:** issue where cache timestamps wouldn't be updated once created ([5156040](5156040))
* **commands:** [#151](#151) don't rely on alfred input filtering, remove uids ([92d9ac4](92d9ac4))
* **commands:** certain characters not (" and \) being parsed ([d53d68f](d53d68f))
* **commands:** error when trying to retrieve a non existent project ([42e0009](42e0009))
* **project:** unhelpful error message when missing todoist token in settings ([5a0af91](5a0af91))
* **settings:** [#152](#152) settings break with multiple consecutive spaces ([b3f2f2a](b3f2f2a))
* **todoist:** task cache not being refreshed ([179c0bc](179c0bc))
* alfred workflow version is the same as the release version again ([0ce67a3](0ce67a3))
* updater not picking up new prereleases, please update manually ([fdcb793](fdcb793))
* updater not storing last update timestamp ([35ff532](35ff532))

### Features

* **commands:** [#13](#13) sort by due date by default ([32044b0](32044b0))
* **commands:** filter tasks directly through Todoist ([f9bd460](f9bd460)), closes [#13](#13) [#20](#20) [#72](#72)
* **parser:** reimplement date from now for timestamped tasks ([cd090d8](cd090d8))
* **project:** full rewrite ([2849c8a](2849c8a)), closes [#128](#128) [#126](#126) [#20](#20) [#124](#124) [#128](#128) [#126](#126) [#124](#124) [#20](#20)
* **project:** provide a useful error as a list item when node.js is not installed ([e039157](e039157))

### BREAKING CHANGES

* **project:** Improve string parsing, now requires id for project, labels and sections
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant