Update and fix typing #378
Conversation
|
Thanks! |
| obj: object, | ||
| base_type: Union[ | ||
| type, Tuple[Union[type, Tuple[Any, ...]], ...], None | ||
| ] = ..., |
There was a problem hiding this comment.
@ilai-deutel
Since a lot of this seems to just about wrapping for line-length I've wanted to mention that it is typically OK for .pyi files to have long lines, and a special flake8 config can be used to handle that (#376).
Also (larger) style changes are better off in a separate commit then also.
(just for info / my 2 cents)
There was a problem hiding this comment.
I used black to format the .pyi with the same parameters as I used when I initially created the .pyi files, which are the ones used for the .py files (black -S -l 79 as in #306). typeshed uses a line length of 130 for stub files and it was suggested to become the default in psf/black#341, but the project maintainer decided otherwise.
79 characters for regular Python files and 130 for stub files sounds reasonable to me, what do you think @bbayles? Also, if black is enforced across the project, there could be black checks in the travis config in addition to flake8.
There was a problem hiding this comment.
I'm in favor of re-formatting everything with black, and enforcing it in Travis. I'll do that for a future release.
This PR updates the type stubs for new methods (
buckets.__iter__,numeric_range.*) and fixes type hints forsampleandgrouper.