-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-hot-loader error #2
Comments
Hello. I can't reproduce the issue. Try |
still the same error after running those commands. let me know if you have any ideas on how to troubleshoot this. thanks. |
Can you try to reproduce on fresh checkout or even on a different machine? |
i actually did this yesterday, with the same error (fresh VM, installed git/node/npm, checked out the repo). I'm not sure what I could be doing wrong? It wasn't quite as simple as "npm run start". I believe I had to do "npm install webpack -g" and "npm update" before "npm run start" would work. I also tried installing the "react-hot-boilerplate" template, and tweaked that to use the same dependencies as todomvc-moreartyjs. Hot update was working without error until I added Morearty and the code in the todomvc-moreartyjs "app.js" file, and then I started getting the error about "duplicate displayName". |
have you been able to reproduce this? i tried again with a clean linux VM today and ended up with the same error message. |
I cloned the the repo from scratch and started the app without problems. Try to pull again, I've updated Immutable version. |
thanks for taking a look. i cloned from scratch and i'm still seeing the same error. note that i also can start the app without any problem. i'm only seeing the error in the browser console when i make a change to "app.js" and save the file. |
have you been able to reproduce the issue when saving changes to "app.js"? if not, any ideas what i could be doing wrong? |
Yep, I've reproduced it. Try to inject Bootstrap component without jsx.
|
i'm not able to work around this. much appreciated if you can push a fix or provide more detailed instructions for a workaround. thanks. |
Ok, the fix is here. I put the Bootstrap wrapper in the separate module to prevent it creation on each app.jsx reload. Now you can use hot-loader with jsx, but it won't reload the app if you change a state directly in your code. Let me know if this helped you. |
yes, this resolved the issue. thanks, much appreciated. |
when i change anything in app.js, i get this error in the browser console:
"Cannot not apply hot update to app.js: Found duplicate displayName in Morearty.js: "Bootstrap".
react-hot-loader uses displayName to distinguish between several components in one file."
The text was updated successfully, but these errors were encountered: