Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Concat that's been obsolete since 3.0 #993

Closed
atifaziz opened this issue Apr 2, 2023 · 3 comments · Fixed by #1002
Closed

Remove Concat that's been obsolete since 3.0 #993

atifaziz opened this issue Apr 2, 2023 · 3 comments · Fixed by #1002
Milestone

Comments

@atifaziz
Copy link
Member

atifaziz commented Apr 2, 2023

The Concat method was superseded by Append (see #496) and Concat has been marked obsolete since version 3.0. It's time to remove it with the next major version.

@atifaziz atifaziz added this to the 4.0 milestone Apr 2, 2023
@pflajszer
Copy link
Contributor

pflajszer commented Apr 24, 2023

Hey atifaziz. I can see that Concat already calls Append internally. Is is just a matter of removing that single method in Append.cs?
It's also in the README, so not sure if you'd like to keep it there too for now.

Happy to take that one if you're ok with that?
I'm just getting comfortable contributing to OS projects, so that looks like a reasonable one to start with.

Thanks

@atifaziz
Copy link
Member Author

atifaziz commented May 5, 2023

Is is just a matter of removing that single method in Append.cs?

Yes.

It's also in the README, so not sure if you'd like to keep it there too for now.

It's already crossed out, but for starters, we can just change the following:

This method is obsolete and will be removed in a future version.

to

This method was removed with version 4.0.

Happy to take that one if you're ok with that?

Awesome.

I'm just getting comfortable contributing to OS projects, so that looks like a reasonable one to start with.

It's definitely a light one to get started with. Good luck and look forward to your PR.

@pflajszer
Copy link
Contributor

Thanks a lot @atifaziz . Here's the PR: link. Please let me know if that looks OK!

atifaziz pushed a commit that referenced this issue Jun 24, 2023
This is a squashed merge of PR #1002 that closes #993.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants