Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed closures in favour of private static methods to close issue #906 #1064

Merged
merged 17 commits into from
May 1, 2024
Merged

Removed closures in favour of private static methods to close issue #906 #1064

merged 17 commits into from
May 1, 2024

Commits on Apr 25, 2024

  1. Removed closures in favour of private static methods

    @JacobSilasBentley
    JacobSilasBentley committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    0e4ddbc View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Updated test so that result of the Rank method is only iterated once.

    @JacobSilasBentley
    JacobSilasBentley committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    0ba5768 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Updated method argument order for consistency

    @JacobSilasBentley
    JacobSilasBentley committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    5d0067a View commit details
    Browse the repository at this point in the history

  2. Removed erroneous space. 

    Co-authored-by: Atif Aziz <code@raboof.com>
    @JacobSilasBentley @atifaziz
    JacobSilasBentley and atifaziz committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    3fea372 View commit details
    Browse the repository at this point in the history

  3. Calling ToArray on the result of the Rank method to avoid multiple en… 

    …umerations when testing the result.

Co-authored-by: Atif Aziz <code@raboof.com>
    @JacobSilasBentley @atifaziz
    JacobSilasBentley and atifaziz committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    236df73 View commit details
    Browse the repository at this point in the history

  4. Updated method argument alignment. 

    Co-authored-by: Atif Aziz <code@raboof.com>
    @JacobSilasBentley @atifaziz
    JacobSilasBentley and atifaziz committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    2d62f8d View commit details
    Browse the repository at this point in the history

  5. Inlined the result of the Extrema method. 

    Co-authored-by: Atif Aziz <code@raboof.com>
    @JacobSilasBentley @atifaziz
    JacobSilasBentley and atifaziz committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    77c50e8 View commit details
    Browse the repository at this point in the history

  6. Updated alignment of arguments. 

    Co-authored-by: Atif Aziz <code@raboof.com>
    @JacobSilasBentley @atifaziz
    JacobSilasBentley and atifaziz committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    72f6f1b View commit details
    Browse the repository at this point in the history

  7. Merge branch 'removing-closures' of https://github.com/JacobSilasBent… 

    …ley/MoreLINQ into removing-closures
    @JacobSilasBentley
    JacobSilasBentley committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    d700e4f View commit details
    Browse the repository at this point in the history

  8. Remove unused method argument.

    @JacobSilasBentley
    JacobSilasBentley committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    955a6fa View commit details
    Browse the repository at this point in the history

  9. Updated more Methods to use private static methods instead of closures.

    @JacobSilasBentley
    JacobSilasBentley committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    2241256 View commit details
    Browse the repository at this point in the history

  10. Fix alignment of "Flatten" (type) args

    @atifaziz
    atifaziz committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    b6608c4 View commit details
    Browse the repository at this point in the history

  11. Format "Cartesian" args layout to be consistenly vertical

    @atifaziz
    atifaziz committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    aca7772 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Reverted making GetEnumerator implementation static.

    @JacobSilasBentley
    JacobSilasBentley committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    66ffc8f View commit details
    Browse the repository at this point in the history

  2. Split initialisation logic and enumeration logic into seperate privat… 

    …e methods.
    @JacobSilasBentley
    JacobSilasBentley committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    fe4aba3 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Revert "Split initialisation logic and enumeration logic into seperat… 

    …e private methods."

This reverts commit fe4aba3.
    @JacobSilasBentley
    JacobSilasBentley committed May 1, 2024
    Configuration menu
    Copy the full SHA
    44dd945 View commit details
    Browse the repository at this point in the history

  2. Reverting styling changes to code.

    @JacobSilasBentley
    JacobSilasBentley committed May 1, 2024
    Configuration menu
    Copy the full SHA
    ad154a8 View commit details
    Browse the repository at this point in the history