Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to .NET SDK 8.0.2xx #1069

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

atifaziz
Copy link
Member

This PR pins the solution to .NET SDK 8.0.2xx. Up to now, the roll-forward policy was latest feature, but .NET SDK 8.0.300 introduces a regressions which causes compilation to fail due to the following code analysis errors:

bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(1,1): error IDE0240: Nullable directive is redundant (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0240)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(45,17): error IDE0010: Populate switch (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0010)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(69,21): error IDE0010: Populate switch (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0010)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(81,37): error IDE0010: Populate switch (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0010)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(86,45): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(92,45): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(98,45): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(104,45): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(113,33): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(119,29): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(133,37): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(139,33): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(145,29): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(155,33): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(161,29): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(170,17): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(176,13): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)

To avoid being subjected to future regressions, it seems safer to roll-forward to latest patch only.

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.62%. Comparing base (9a2cc9f) to head (bb478ee).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1069   +/-   ##
=======================================
  Coverage   93.62%   93.62%           
=======================================
  Files         112      112           
  Lines        3374     3374           
  Branches      957      956    -1     
=======================================
  Hits         3159     3159           
  Misses        199      199           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atifaziz atifaziz merged commit bb478ee into morelinq:master May 20, 2024
7 checks passed
@atifaziz atifaziz deleted the pin-dotnet-sdk-8.0.2xx branch May 20, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant