Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Exclude to not call MoveNext past end of sequence #692

Merged
merged 6 commits into from
Jan 21, 2023
Merged

Fix Exclude to not call MoveNext past end of sequence #692

merged 6 commits into from
Jan 21, 2023

Conversation

Orace
Copy link
Contributor

@Orace Orace commented Nov 12, 2019

This PR addresses #665

@Orace
Merge pull request #2 from morelinq/master
201e376 
Merge MoreLINQ master into mlMaster
@Orace
Update ExcludeTest.cs
b959af1 
Add TestExclude to test known cases.
@Orace
Update Exclude.cs
c0f165e 
Fix calls to MoveNext on sequence end.
@Orace
Update ExcludeTest.cs
6a59821 
Fix trailing white space.
This was referenced Nov 12, 2019
Closed
Closed
@Orace Orace changed the title Exclude, add test, fix implementation Fix Exclude to not call MoveNext past end of sequence Nov 12, 2019
@atifaziz atifaziz changed the title Fix Exclude to not call MoveNext past end of sequence Fix Exclude to not call MoveNext past end of sequence Jan 20, 2023
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #692 (e3c5560) into master (c081197) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head e3c5560 differs from pull request most recent head 7a85c95. Consider uploading reports for the commit 7a85c95 to get more accurate results

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
+ Coverage   92.41%   92.42%   +0.01%     
==========================================
  Files         112      112              
  Lines        3439     3446       +7     
  Branches     1021     1023       +2     
==========================================
+ Hits         3178     3185       +7     
  Misses        199      199              
  Partials       62       62
Impacted Files Coverage Δ
MoreLinq/Exclude.cs 96.42% <100.00%> (+1.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

atifaziz
atifaziz approved these changes Jan 21, 2023
View reviewed changes
Copy link
Member

@atifaziz atifaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix! I updated the tests to using TestingSequence<T>, which highlighted the issue without the need for adding a new test (as was done initially).

@atifaziz atifaziz merged commit 62914fb into morelinq:master Jan 21, 2023
@viceroypenguin viceroypenguin mentioned this pull request Jan 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atifaziz atifaziz atifaziz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Orace @atifaziz