Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interleave: Do not call GetEnumerator eagerly #730

Merged
merged 3 commits into from
Aug 11, 2020

Conversation

Orace
Copy link
Contributor

@Orace Orace commented Dec 12, 2019

This PR addresses #729.

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #730 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
+ Coverage   91.86%   91.89%   +0.02%     
==========================================
  Files         107      107              
  Lines        3490     3502      +12     
==========================================
+ Hits         3206     3218      +12     
  Misses        284      284
Impacted Files Coverage Δ
MoreLinq/Interleave.cs 97.95% <100%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31cb640...0316143. Read the comment docs.

@Orace Orace mentioned this pull request Dec 12, 2019
@atifaziz atifaziz linked an issue Aug 6, 2020 that may be closed by this pull request
@atifaziz atifaziz changed the title Interleave: Do not call GetEnumerator eagerly. Interleave: Do not call GetEnumerator eagerly Aug 11, 2020
Copy link
Member

@atifaziz atifaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!


PS Sorry for neglecting this due to my unavailability.

@atifaziz atifaziz merged commit 780d323 into morelinq:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interleave eagerly calls GetEnumerator
2 participants