Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SortedMerge: Test do not call MoveNext eagerly #735

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

Orace
Copy link
Contributor

@Orace Orace commented Dec 12, 2019

This PR add TestSortedMergeDoNotCallMoveNextEagerly.
Unlike for Interleave (#694), this test pass.

Copy link
Member

@atifaziz atifaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW after all this time, just one change and we can merge this.

Thanks @Orace!

MoreLinq.Test/SortedMergeTest.cs Outdated Show resolved Hide resolved
Co-authored-by: Atif Aziz <code@raboof.com>
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@9fc8486). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 65a341f differs from pull request most recent head 720c020. Consider uploading reports for the commit 720c020 to get more accurate results

@@            Coverage Diff            @@
##             master     #735   +/-   ##
=========================================
  Coverage          ?   92.57%           
=========================================
  Files             ?      113           
  Lines             ?     3422           
  Branches          ?     1055           
=========================================
  Hits              ?     3168           
  Misses            ?      191           
  Partials          ?       63           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@atifaziz atifaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@atifaziz atifaziz merged commit a9437d4 into morelinq:master Jun 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants