Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null check for Partition #896

Merged
merged 1 commit into from
Nov 20, 2022
Merged

Add null check for Partition #896

merged 1 commit into from
Nov 20, 2022

Conversation

viceroypenguin
Copy link
Contributor

This introduces a null-check in order to fail-fast on a null resultSelector value.

@atifaziz atifaziz changed the title Add null-check for Partition() Add null checks for Partition Nov 19, 2022
@atifaziz atifaziz changed the title Add null checks for Partition Add null check for Partition Nov 19, 2022
Copy link
Member

@atifaziz atifaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Merging #896 (e6745b8) into master (b31c7fd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #896   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         110      110           
  Lines        3441     3442    +1     
  Branches     1020     1021    +1     
=======================================
+ Hits         3179     3180    +1     
  Misses        200      200           
  Partials       62       62           
Impacted Files Coverage Δ
MoreLinq/Partition.cs 98.27% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atifaziz atifaziz merged commit 41a4195 into morelinq:master Nov 20, 2022
@viceroypenguin viceroypenguin deleted the partition-nullcheck branch November 20, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants