Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire our delegating Comparer #921

Merged
merged 3 commits into from
Jan 15, 2023
Merged

Conversation

atifaziz
Copy link
Member

This PR removes Comparer in favour of Delegate.Comparer from Delegating that provides the same functionality.

Copy link
Contributor

@viceroypenguin viceroypenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason not to use System.Collections.Generic.Comparer<T>.Create()? (available since net4.5 per https://learn.microsoft.com/en-us/dotnet/api/system.collections.generic.comparer-1.create?view=net-7.0)

@atifaziz
Copy link
Member Author

Is there a reason not to use System.Collections.Generic.Comparer<T>.Create()?

None. It's what happens when you work late. 😉 Thanks for the review! Fixed with c3dfb19.

@atifaziz atifaziz changed the title Use Delegate.Comparer, retiring Comparer Retire our delegating Comparer Jan 15, 2023
@codecov
Copy link

codecov bot commented Jan 15, 2023

Codecov Report

Merging #921 (d625bcd) into master (34c7ebe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #921   +/-   ##
=======================================
  Coverage   92.44%   92.44%           
=======================================
  Files         112      112           
  Lines        3440     3440           
  Branches     1018     1018           
=======================================
  Hits         3180     3180           
  Misses        199      199           
  Partials       61       61           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atifaziz atifaziz merged commit 78b8699 into morelinq:master Jan 15, 2023
@atifaziz atifaziz deleted the x-comparer branch January 15, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants