Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate structural differences in *Like types #949

Merged
merged 1 commit into from
Jan 28, 2023

Conversation

atifaziz
Copy link
Member

This PR consolidate structural differences between CollectionLike<T> and ListLike<T>:

  • The TryAsCollectionLike as extension is moved to CollectionLike.
  • Type construction helpers for ListLike<T> are in-lined due to single use.

@atifaziz atifaziz self-assigned this Jan 27, 2023
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #949 (38c12bb) into master (c8004ac) will decrease coverage by 0.01%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master     #949      +/-   ##
==========================================
- Coverage   92.44%   92.43%   -0.01%     
==========================================
  Files         113      113              
  Lines        3453     3451       -2     
  Branches     1025     1025              
==========================================
- Hits         3192     3190       -2     
  Misses        196      196              
  Partials       65       65              
Impacted Files Coverage Δ
MoreLinq/MoreEnumerable.cs 100.00% <ø> (+5.88%) ⬆️
MoreLinq/CollectionLike.cs 82.35% <85.71%> (+2.35%) ⬆️
MoreLinq/ListLike.cs 85.71% <100.00%> (-1.25%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atifaziz atifaziz merged commit a610d3a into morelinq:master Jan 28, 2023
@atifaziz atifaziz deleted the cons-diff-likes branch January 28, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants