Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moban 0.4.5 test failures on openSUSE Tumbleweed #275

Closed
jayvdb opened this issue Jul 8, 2019 · 1 comment · Fixed by #313
Closed

moban 0.4.5 test failures on openSUSE Tumbleweed #275

jayvdb opened this issue Jul 8, 2019 · 1 comment · Fixed by #313

Comments

@jayvdb
Copy link
Member

jayvdb commented Jul 8, 2019

I havent built on openSUSE since 0.3.10, so this probably has been around for a while

[   79s] ======================================================================
[   79s] FAIL: test_command_line_options.test_duplicated_targets_in_moban_file
[   79s] ----------------------------------------------------------------------
[   79s] Traceback (most recent call last):
[   79s]   File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
[   79s]     self.test(*self.arg)
[   79s]   File "/usr/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
[   79s]     return func(*args, **keywargs)
[   79s]   File "/home/abuild/rpmbuild/BUILD/moban-0.4.5/tests/integration_tests/test_command_line_options.py", line 333, in test_duplicated_targets_in_moban_file
[   79s]     assert_raises(SystemExit, main)
[   79s] AssertionError: SystemExit not raised
[   79s] -------------------- >> begin captured stdout << ---------------------
[   79s] Error: setup.py cannot be found
[   79s] Error: setup.py cannot be found
[   79s] Everything is up to date!
[   61s] ======================================================================
[   61s] ERROR: tests.mobanfile.test_mobanfile.test_handle_targets_sequence
[   61s] ----------------------------------------------------------------------
[   61s] Traceback (most recent call last):
[   61s]   File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
[   61s]     self.test(*self.arg)
[   61s]   File "/usr/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
[   61s]     return func(*args, **keywargs)
[   61s]   File "/home/abuild/rpmbuild/BUILD/moban-0.4.5/tests/mobanfile/test_mobanfile.py", line 179, in test_handle_targets_sequence
[   61s]     call_args[1][0][0][0],
[   61s] IndexError: list index out of range

It can be reproduced by branching https://build.opensuse.org/package/show/home:jayvdb:moban/python-moban and editing the spec to remove "test_duplicated_targets_in_moban_file" and "test_handle_targets_sequence" from the excluded tests.

The only potential cause I am aware of is not including the handlebars plugin.

@jayvdb jayvdb changed the title moban 0.4.5 test failures on openSUSE moban 0.4.5 test failures on openSUSE Tumbleweed Jul 8, 2019
@chfw chfw mentioned this issue Aug 17, 2019
3 tasks
@chfw
Copy link
Member

chfw commented Aug 17, 2019

will be fixed in v0.6.0

@chfw chfw closed this as completed Aug 17, 2019
chfw added a commit that referenced this issue Aug 18, 2019
* 🔥 remove appdirs and gitpython from moban dependency list

* 📚 add a use case: template from a s3 bucket

* ✨ add -d for development tracing. fix #185

* 🚜 do not log the exception but as info

* 📚 update documenation

* 🐛 moban -t url -c url -o moban.output failes

* 🔬 more tests

* 👕 fix format

* 📚 update change log and readme

* 🔥 remove unused imports

* 🔬 more tests

* 👕 fix coding style

* 📚 update package url link

* 💚 make travis tests pass

* 💚 make windows tests pass. an osfs was passed to multifs and the invalid characters on windows are different from the ones on linx. hence pypifs and gitfs2 url are seen as invalid on windows. PyFilesystem/pyfilesystem2#347

* 🔥 remove adapter folder

* 🐛 fix build failure on opensuse. resolves #275

* ✨ use released version of pypifs

* 📰 add pypifs as test dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants