MultiFS's isfile behavior #347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…provide FSURL string.
…lder')) triggers CreateFailed 🐛 osfs.geturl() cannot be opened by itself
✨ url quote the files for proper url string
…itfs, fs.datalake et al. fix #340
… and linux file uri
chfw
added a commit
to moremoban/moban
that referenced
this pull request
Aug 17, 2019
…lid characters on windows are different from the ones on linx. hence pypifs and gitfs2 url are seen as invalid on windows. PyFilesystem/pyfilesystem2#347
chfw
added a commit
to moremoban/moban
that referenced
this pull request
Aug 17, 2019
…lid characters on windows are different from the ones on linx. hence pypifs and gitfs2 url are seen as invalid on windows. PyFilesystem/pyfilesystem2#347
chfw
added a commit
to moremoban/moban
that referenced
this pull request
Aug 18, 2019
* 🔥 remove appdirs and gitpython from moban dependency list * 📚 add a use case: template from a s3 bucket * ✨ add -d for development tracing. fix #185 * 🚜 do not log the exception but as info * 📚 update documenation * 🐛 moban -t url -c url -o moban.output failes * 🔬 more tests * 👕 fix format * 📚 update change log and readme * 🔥 remove unused imports * 🔬 more tests * 👕 fix coding style * 📚 update package url link * 💚 make travis tests pass * 💚 make windows tests pass. an osfs was passed to multifs and the invalid characters on windows are different from the ones on linx. hence pypifs and gitfs2 url are seen as invalid on windows. PyFilesystem/pyfilesystem2#347 * 🔥 remove adapter folder * 🐛 fix build failure on opensuse. resolves #275 * ✨ use released version of pypifs * 📰 add pypifs as test dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
It may not be an issue. Please let me try appveyor with my newly added test case. If it is a false positive, I will close the PR.
Here is the trigger for my suspicion: https://dev.azure.com/moremoban/moban/_build/results?buildId=865, where all unit tests went OK but not on Windows.