Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups of targets #62

Closed
jayvdb opened this issue Jun 8, 2018 · 4 comments
Closed

Groups of targets #62

jayvdb opened this issue Jun 8, 2018 · 4 comments
Assignees
Milestone

Comments

@jayvdb
Copy link
Member

jayvdb commented Jun 8, 2018

I need to be able to regenerate only three of the targets which need to be in sync, where the complete list contains many more targets which should not be updated.

I could manually invoke moban three times.

But it would be better to add labels to targets, so they can be grouped together.

@chfw
Copy link
Member

chfw commented Jun 8, 2018

yes, label can be added but don't forget moban have a command line interface too so it will take a while to get it right.

What about the alternative: create three moban file and use moban -m group1.yml, moban -m group2.yml and moban -m group3.yml

@jayvdb jayvdb added this to the 0.5.0 milestone Jan 24, 2019
@jayvdb
Copy link
Member Author

jayvdb commented Jan 24, 2019

Possibly we can have three separate mobanfile , and then a global mobanfile which overrides all three to use moban's yaml merging feature.

chfw added a commit that referenced this issue Feb 14, 2019
…#62 with current restriction on template type as key. What will happen if template type as group key is unknown, atm it will be treated as jinja2 template type
chfw added a commit that referenced this issue Feb 16, 2019
* ✨ initial prototype

* ✨ first working prototype that having relocated copy: into targets:. #165

* 📰 add missing unit test file

* ♿ deprecate copy: key word. #165

* 📰 add the missing file

* 🔨 code refactoring with TemplateTarget. replace all template tuples with TemplateTarget

* 💚 install pypi-mobans-pkg for testing

* 🔥 remove added test package: pypi-mobans-pkg

* 🐛 when new plugins are installed, call the lml scanner again so that newly installed packages are loaded, pypi-moban-pkg should be reloaded in the test, #165

* 🔨 refactor constants.py

* 🔥 remove previous fix for pypi-mobans-pkg not found. #165

* 📚 update copy action documentation and update integration tests 🔬

* 💄 minor update

* 🚜 relocating files

* 🚜 code refactoring on plugins.py

* 🚜 flatten concentrated files

* 🚜 fusing engines to template.py

* 🚜 relocate copier to plugins

* ✨ first working prototype: copy as template engine. #165

* 💚 fix unit test failure because of dependency

* 🔨 code refactoring, support template a directory as it used to, template-folder/a.jj2 become dest/a without jj2 suffix. it also means: copy-folder/me.copy becomes dest-folder/me but no effect if copy-folder/you, as it dest-folder/you

* 💚 try to fix broken unit tests in travis-ci

* 🐛 fix the bug where repo is not found if it is newly installed. #165

* 🔨 respect default template type

* 🔥 remove useless function as code evolves

* 🔨 code refactor magic copy label

* 🔬 test content forward engine, nickname copy engine. #165

* 🔥 remove useless report functions

* 🔥 remove unreachable test codes and remove unused code

* ✨ support group targets with template type, #165. And it is related to #62 with current restriction on template type as key. What will happen if template type as group key is unknown, atm it will be treated as jinja2 template type

* ✨ force template type regardless of individual template types. #165

* 💚 fix broken tests

* 🔬 more test coverage

* 🚜 rename docs directory

* 🔨 code refactoring

* 🔨 code refactoring on targets

* 🚜 re-organising file structures

* 🚜 re-organize repo related functionality

* 🚜 re-organize template target parsing functionality for moban file

* 📚 update documentation

* 📚 document 'copy' engine

* 🔨 black all source code

* 📚 update change log

* 💄 update gitignore

* 🔬 squeeze more test coverage from test code

* :micrscope: more test coverage

* 🔬 more tests on mobanfile targets

* 🔨 relocate test files

* 🔬 more tests on mobanfile targets

* 🚜 relocate test file

* 🔬 more tests

* 📚 update documentation index

* 📚 update change log
@chfw
Copy link
Member

chfw commented Feb 16, 2019

A few more changes could enable this grouping feature.

  1. Enable cli to execute a group key
  2. Allow non template type name as group key.

@chfw
Copy link
Member

chfw commented Feb 16, 2019

Current implementation can be found at level 16.

@chfw chfw added this to back-log in 0.7.x Feb 17, 2019
@chfw chfw moved this from back-log to in-progress in 0.7.x Feb 23, 2019
@chfw chfw self-assigned this Mar 6, 2019
@chfw chfw moved this from in-progress to done in 0.7.x Mar 7, 2019
@chfw chfw closed this as completed Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants