Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Mar 7, 2019

delivers #62

it would work as intended if a template type name is elected as a group target name.

yet to explore: choose a random name as group target name.

@chfw chfw requested review from CLiu13, ayan-b and jayvdb March 7, 2019 07:31
@codecov-io
Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #249 into dev will decrease coverage by 0.11%.
The diff coverage is 93.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #249      +/-   ##
==========================================
- Coverage   99.26%   99.14%   -0.12%     
==========================================
  Files          57       57              
  Lines        2434     2469      +35     
==========================================
+ Hits         2416     2448      +32     
- Misses         18       21       +3
Impacted Files Coverage Δ
moban/mobanfile/__init__.py 99.24% <100%> (+0.01%) ⬆️
moban/constants.py 100% <100%> (ø) ⬆️
moban/main.py 100% <100%> (ø) ⬆️
moban/exceptions.py 100% <100%> (ø) ⬆️
tests/test_docs.py 100% <100%> (ø) ⬆️
tests/mobanfile/test_targets.py 97.1% <86.66%> (-2.9%) ⬇️
moban/mobanfile/targets.py 96.92% <88.88%> (-1.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a2582b...a6f0ecb. Read the comment docs.

@chfw chfw merged commit 057cfbd into dev Mar 7, 2019
@chfw chfw deleted the group-target branch March 7, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants