Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of little_helpers services container. #228

Draft
wants to merge 2 commits into
base: 7.x-2.x
Choose a base branch
from
Draft

Conversation

torotil
Copy link
Contributor

@torotil torotil commented Apr 29, 2020

No description provided.

@torotil torotil marked this pull request as draft April 29, 2020 19:39
@torotil torotil force-pushed the lh-plugins branch 3 times, most recently from 90c9c95 to b792a9d Compare April 29, 2020 19:55
@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #228 (e9b6ae9) into 7.x-2.x (e94330d) will decrease coverage by 32.78%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             7.x-2.x     #228       +/-   ##
==============================================
- Coverage      47.43%   14.64%   -32.79%     
==============================================
  Files            290       37      -253     
  Lines          10179     1031     -9148     
  Branches         154      154               
==============================================
- Hits            4828      151     -4677     
+ Misses          5348      877     -4471     
  Partials           3        3               
Impacted Files Coverage Δ Complexity Δ
src/CRM/Export/WrapperField.php
campaignion_donation_amount/src/Utils.php
campaignion_action/src/Redirects/Endpoint.php
...webform_results/campaignion_webform_results.module
...paignion_manage/src/BulkOp/SupporterNewsletter.php
...aignion_manage/src/Filter/ContentNodeReference.php
campaignion_manage/src/Filter/SupporterState.php
campaignion_manage/src/BulkOp/ContentUnpublish.php
campaignion_test/src/Supporter.php
campaignion_newsletters/src/Subscriptions.php
... and 237 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e94330d...e9b6ae9. Read the comment docs.

@torotil torotil force-pushed the lh-plugins branch 4 times, most recently from b59e123 to 916d937 Compare May 4, 2020 12:59
@torotil torotil changed the title e2t: Selection modes → little_helpers service container. Make use of little_helpers services container. May 6, 2020
*/
function hook_campaignion_action_info() {
$types['webform'] = array(
'class' => 'Drupal\\campaignion_action\\FlexibleForm',
'type' => 'default',
'wizard' => 'default',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will still need some code to work with legacy profiles (ie. map backwards from action_class and wizard_class).

campaignion_action/campaignion_action.info Outdated Show resolved Hide resolved
campaignion_email_to_target/src/Action.php Outdated Show resolved Hide resolved
campaignion_email_to_target/src/Loader.php Outdated Show resolved Hide resolved
* Implements hook_campaignion_wizard_info().
*/
function campaignion_wizard_campaignion_wizard_info() {
$info['donation'] = DonationWizard::class;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move this into campaignion_donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant