Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #131 #160

Merged
merged 1 commit into from
Apr 30, 2022
Merged

feat: #131 #160

merged 1 commit into from
Apr 30, 2022

Conversation

mauroerta
Copy link
Collaborator

Proposed changes

Referring the issue #131, a new feature has been added to generate predictable class names for a given style.
To do it, the value of the class generated by jss is calculated based on the style object, for example:

const style = {
 bg: 'primary'
};
// will generate
const className = 'bg-primary';

Closes #131

Types of changes

  • 🐛 Bugfix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality or enhancements)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ✅ Tests (added tests for an existing feature)
  • 📚 Documentation Update (if none of the other choices apply)
  • 🙌 Other (please, write a clear and concise description of the proposal in the section above)

Checklist

  • 👀 I have read the CONTRIBUTING doc
  • ✅ Lint and unit tests pass locally with my changes
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • 📚 I have added necessary documentation (if appropriate)
  • 🔀 Any dependent changes have been merged and published in downstream modules

@netlify
Copy link

netlify bot commented Apr 30, 2022

Deploy Preview for cocky-kare-d8d81e ready!

Name Link
🔨 Latest commit 1bf617c
🔍 Latest deploy log https://app.netlify.com/sites/cocky-kare-d8d81e/deploys/626ce9eea62f49000815a29c
😎 Deploy Preview https://deploy-preview-160--cocky-kare-d8d81e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mauroerta mauroerta added the enhancement New feature or request label Apr 30, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #160 (1bf617c) into main (d47cea7) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #160   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       103    +1     
  Lines          893       915   +22     
  Branches       121       124    +3     
=========================================
+ Hits           893       915   +22     
Impacted Files Coverage Δ
packages/jss/src/generateClassName.ts 100.00% <100.00%> (ø)
packages/jss/src/morfeoJSS.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d47cea7...1bf617c. Read the comment docs.

@andreaSimonePorceddu andreaSimonePorceddu merged commit ea7991e into main Apr 30, 2022
@mauroerta mauroerta deleted the feature/131 branch April 30, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Predictable css class generator
3 participants