chore: add visitors

[maastrich]

what does it do?

Add visitors for remaining nodes types with tests for most of them

why?

I was planning do make a similar package but you seem to have handled most of the work and that I could handle some of the rest

[maastrich]

Hello @morganney I was thinking that you could use some help, tell me if it's ok ;)

[codecov]

Codecov Report

Attention: Patch coverage is 97.32771% with 19 lines in your changes missing coverage. Please review.

Project coverage is 97.54%. Comparing base (41f14e2) to head (9aa6299).

Files	Patch %	Lines
src/baseVisitor.ts	97.32%	14 Missing and 5 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main       #2       +/-   ##
===========================================
+ Coverage   53.06%   97.54%   +44.47%     
===========================================
  Files           2        2               
  Lines         620     1057      +437     
  Branches       12       77       +65     
===========================================
+ Hits          329     1031      +702     
+ Misses        291       21      -270     
- Partials        0        5        +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[maastrich]

Almost done, but a few things to take care about aggregate types
I'll take care of them in the morning, it's getting late in paris

[morganney]

bonne nuit.

[maastrich]

hello @morganney, I've updated the PR with some tests, do you think this kind of tests works for you ?

[morganney]

I think it is a solid approach, I like it. Thanks. I've got a couple questions/comments though if you don't mind.

[morganney]

@maastrich I've created branch pr/2-suggested-changes if you wanted to rebase this work off of that. Either that or work from my comments, up to you. I appreciate your help. I'll be able to continue collaborating after work.

[maastrich]

Hey @morganney, I've made some pretty good advancements, coverage is starting to look good and I've patched some of the flaws

Next step is to reset aggregated types and find a workaround about the name conflicts

I've settled on a few tests skips as I do not know how to trigger these nodes visitors

about the tests utils, I moved them in a utils file as you proposed

PS: I've made another PR about AggregatedTypes -> #5

[maastrich]

@morganney I believe that I'm happy with these changes
I've opened a PR on swc to add a missing type (forcing me to add a @ts-expect-error) i'm hopping that it will be merged en published soon

[morganney]

@maastrich mind rebasing with main? I made some changes. Specifically, I wasn't sure why tsconfig.meta.json was necessary so combined it with the main tsconfig file. I also updated the linting and fixed some of those errors.

[maastrich]

@morganney I can revert the meta tsconfig but I usually do that to ensure separation between the actual code and testing/config files
This way, you can ensure that the walker will run on the browser, no node:* needed but they will be defined for the tests 🤔

Your choice

[morganney]

@morganney I can revert the meta tsconfig but I usually do that to ensure separation between the actual code and testing/config files This way, you can ensure that the walker will run on the browser, no node:* needed but they will be defined for the tests 🤔

Your choice

Gotcha. Thanks for explaining your reasoning.

I think in this case, for now anyway, can you combine it to just the one tsconfig.json file? If that ends up being a mistake or the other seems necessary, we can add it back in.

[maastrich]

@morganney sure, done

[maastrich]

btw I've found few examples in swc main repository for the nodes I couldn't test, few of them are still untested but there aren't that much
about coverage, I believe some types aren't correct from swc as the decorators are never undefined 🤔

[morganney]

@maastrich great work!

[morganney]

I can tidy up the README in another PR and then release this later today.