Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gruvbox with C code #34

Merged
merged 2 commits into from Jan 24, 2015
Merged

Improve gruvbox with C code #34

merged 2 commits into from Jan 24, 2015

Conversation

cryptomilk
Copy link
Contributor

Hi,

here are two small improvements. The first makes it easier to identify strings and the second displays compile errors/warnings more prominent. See the two pictures below:

gruvbox string improvement -> http://min.us/i/WV09c3thkZ1A
gruvbox error improvement ->http://minus.com/i/bpBizN0WkXLOJ

-- asn

@cryptomilk
Copy link
Contributor Author

I've rebased it on the latest changes in master ...

@morhetz
Copy link
Owner

morhetz commented Aug 22, 2014

Once again it's not the something I would like to have in my default setup, though that sounds like it could be a nice option. Just gimmie a little bit of time to put my hands on.

@cryptomilk
Copy link
Contributor Author

Ok, so I should make it possible to set a config option to get this behaviour?

@cryptomilk
Copy link
Contributor Author

Ping!

@cryptomilk
Copy link
Contributor Author

Here is a new version with options ...

Signed-off-by: Andreas Schneider <asn@cryptomilk.org>
Signed-off-by: Andreas Schneider <asn@cryptomilk.org>
@morhetz
Copy link
Owner

morhetz commented Jan 24, 2015

I must say sorry for a long hiatus on this issue, and I'm very grateful that you did it yourself. Merged.

morhetz added a commit that referenced this pull request Jan 24, 2015
Improve gruvbox with C code
@morhetz morhetz merged commit ca1e855 into morhetz:master Jan 24, 2015
@ghost
Copy link

ghost commented Jan 9, 2017

Could you please post the screenshots here? The links are broken.

@lfilho
Copy link

lfilho commented May 19, 2017

The image links are dead, unfortunately. (Arrived here via Wiki https://github.com/morhetz/gruvbox/wiki/Configuration ). Thanks for everyone's work!

@rivertam
Copy link

Can we get some images of what this is supposed to do? I set g:gruvbox_improved_strings to both 1 and 0 and I didn't notice a difference as far as I could tell in both C and JavaScript. I'm just curious what it does.

@cryptomilk
Copy link
Contributor Author

cryptomilk commented Feb 28, 2019

Here: https://xor.cryptomilk.org/pics/gruvbox_strings.png

let g:gruvbox_italicize_strings=0                                                                                                                                                        
let g:gruvbox_improved_strings=1                                                                                                                                                         

@rivertam
Copy link

rivertam commented Mar 1, 2019

@cryptomilk Thanks, so it adds the background? Still not clear on what "improved" means.

@cryptomilk
Copy link
Contributor Author

Improved readability ;-)

@rpdelaney
Copy link

Improved readability ;-)

I still don't know what this does. You are saying why it does what it does, not what it does. Does it add the background? A before/after screenshot pair would be ideal

@hneis
Copy link

hneis commented May 2, 2020

Improved readability ;-)

I still don't know what this does. You are saying why it does what it does, not what it does. Does it add the background? A before/after screenshot pair would be ideal

Improvement changes strings in quotes color(green) to normal color

@Climax777
Copy link

Improved readability ;-)

I still don't know what this does. You are saying why it does what it does, not what it does. Does it add the background? A before/after screenshot pair would be ideal

Improvement changes strings in quotes color(green) to normal color

I've noticed this too. I've opted to not use this feature because of that.

@marcelofern
Copy link

Same ^ Having a not-coloured string actually didn't help readability for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants