#3074 #2765 Applying CS and adding lacking types wherever holes have been forgotten #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
force-pushed
the
fix-last-insert-id-consistency
branch
4 times, most recently
from
5746e9f
to
8d1ebf7
Compare
|
@Ocramius sorry, didn't notice your PR and fixed CS violations by rebasing. Do you want to rebase on top and keep your type changes? The code style build is green now. |
|
@morozov can do once at the office |
|
Feel free to push into my branch. I'm tired restarting errored MySQL builds on Travis :-\ |
…rever holes have been forgotten
Ocramius
force-pushed
the
chore/fix-last-insert-id-consistency
branch
from
e9daa7b
to
b05053c
Compare
Ocramius
commented
Apr 3, 2018
| @@ -183,7 +183,7 @@ public function trackLastInsertId() : void | |||
| * | |||
| * @return string The last insert ID or '0' in case the last insert ID generated on this connection is unknown. | |||
| * | |||
| * @throws PDOException | |||
| * @throws \PDOException | |||
There was a problem hiding this comment.
Exception type changed to base exception here, since the wrapped connection is accessed directly.
|
@morozov rebased 👍 |
morozov
reviewed
Apr 3, 2018
| @@ -13,7 +13,7 @@ class LastInsertIdTest extends DbalFunctionalTestCase | |||
| /** @var Connection */ | |||
| private $testConnection; | |||
|
|
|||
| protected function setUp() | |||
| protected function setUp() : void | |||
There was a problem hiding this comment.
Should we enforce this in the code style? Or maybe recommend to PHPUnit? Seems working even on PHP 7.2: https://3v4l.org/4QqdS
| @@ -47,27 +47,27 @@ private function createTable($tableName) | |||
| $connection->getSchemaManager()->createTable($table); | |||
| } | |||
|
|
|||
| public function testLastInsertIdNoInsert() | |||
| public function testLastInsertIdNoInsert() : void | |||
There was a problem hiding this comment.
This also could be enforced in the code style.
morozov
added a commit
that referenced
this pull request
Jun 7, 2019
The new version contains some improvements in handling mocks (sebastianbergmann/phpunit#3602) and will help identify some existing issues in DBAL 3.0 tests: There were 2 warnings: 1) Doctrine\Tests\DBAL\Driver\OCI8\OCI8StatementTest::testExecute with data set #0 (array('test', null, 'value')) Method bindValue may not return value of type boolean 2) Doctrine\Tests\DBAL\Driver\OCI8\OCI8StatementTest::testExecute with data set #1 (array(null, 'test', 'value')) Method bindValue may not return value of type boolean
morozov
added a commit
that referenced
this pull request
Jun 7, 2019
The new version contains some improvements in handling mocks (sebastianbergmann/phpunit#3602) and will help identify some existing issues in DBAL 3.0 tests: There were 2 warnings: 1) Doctrine\Tests\DBAL\Driver\OCI8\OCI8StatementTest::testExecute with data set #0 (array('test', null, 'value')) Method bindValue may not return value of type boolean 2) Doctrine\Tests\DBAL\Driver\OCI8\OCI8StatementTest::testExecute with data set #1 (array(null, 'test', 'value')) Method bindValue may not return value of type boolean
morozov
added a commit
that referenced
this pull request
Jun 10, 2019
The new version contains some improvements in handling mocks (sebastianbergmann/phpunit#3602) and will help identify some existing issues in DBAL 3.0 tests: There were 2 warnings: 1) Doctrine\Tests\DBAL\Driver\OCI8\OCI8StatementTest::testExecute with data set #0 (array('test', null, 'value')) Method bindValue may not return value of type boolean 2) Doctrine\Tests\DBAL\Driver\OCI8\OCI8StatementTest::testExecute with data set #1 (array(null, 'test', 'value')) Method bindValue may not return value of type boolean
morozov
pushed a commit
that referenced
this pull request
Dec 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to doctrine#2765 and doctrine#3074