-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User set ignored subs during embedded detection #2494
User set ignored subs during embedded detection #2494
Conversation
ad334c4
to
f7c271c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change is pretty simple, but there are some behavioral changes with Mantine v7 update, can you rebase or merge the development
branch changes.
…encoding may be using a different UTF8 normalization form.
* Use Hamming textdistance library Used Hamming textdistance to sort by closest match. * Global search UI improvements Increased dropdown height to show more results initially (and which can also be scrolled into view). Scrollbars will appear automatically as needed. Remove dropdown when Search box is cleared. * Added textdistance 4.6.2 library
* fix: quotes surround series name not season * feat: Add search via series imdb id * chore: Add comment * fix: Last small fixes
* chore: Bump pysubs2 to v1.7.1 * chore: bump version to 1.7.2 * remove bin
Bumps [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom) from 6.22.3 to 6.23.1. - [Release notes](https://github.com/remix-run/react-router/releases) - [Changelog](https://github.com/remix-run/react-router/blob/main/packages/react-router-dom/CHANGELOG.md) - [Commits](https://github.com/remix-run/react-router/commits/react-router-dom@6.23.1/packages/react-router-dom) --- updated-dependencies: - dependency-name: react-router-dom dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fixed action icon styles * small fixes * fix brand color * more small fixes * fix disabled color for dark * feat: customize highlight and warning badge * chore: Remove hardcoded variables * feat: add text wrap pretty to pop over * fix: pagination position * chore: small adjustments
Bumps the fortawesome group in /frontend with 1 update: [@fortawesome/react-fontawesome](https://github.com/FortAwesome/react-fontawesome). Updates `@fortawesome/react-fontawesome` from 0.2.0 to 0.2.2 - [Release notes](https://github.com/FortAwesome/react-fontawesome/releases) - [Changelog](https://github.com/FortAwesome/react-fontawesome/blob/0.2.x/CHANGELOG.md) - [Commits](FortAwesome/react-fontawesome@0.2.0...0.2.2) --- updated-dependencies: - dependency-name: "@fortawesome/react-fontawesome" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: fortawesome ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fixed mass edit language missing clear * Fixed mass edit profile clear * chore: Remove unused attributes
…operly reintroduced later.
…n-HI only feature.
Bumps the mantine group in /frontend with 6 updates: | Package | From | To | | --- | --- | --- | | [@mantine/core](https://github.com/mantinedev/mantine/tree/HEAD/packages/@mantine/core) | `7.10.1` | `7.10.2` | | [@mantine/dropzone](https://github.com/mantinedev/mantine/tree/HEAD/packages/@mantine/dropzone) | `7.10.1` | `7.10.2` | | [@mantine/form](https://github.com/mantinedev/mantine/tree/HEAD/packages/@mantine/form) | `7.10.1` | `7.10.2` | | [@mantine/hooks](https://github.com/mantinedev/mantine/tree/HEAD/packages/@mantine/hooks) | `7.10.1` | `7.10.2` | | [@mantine/modals](https://github.com/mantinedev/mantine/tree/HEAD/packages/@mantine/modals) | `7.10.1` | `7.10.2` | | [@mantine/notifications](https://github.com/mantinedev/mantine/tree/HEAD/packages/@mantine/notifications) | `7.10.1` | `7.10.2` | Updates `@mantine/core` from 7.10.1 to 7.10.2 - [Release notes](https://github.com/mantinedev/mantine/releases) - [Changelog](https://github.com/mantinedev/mantine/blob/master/CHANGELOG.md) - [Commits](https://github.com/mantinedev/mantine/commits/7.10.2/packages/@mantine/core) Updates `@mantine/dropzone` from 7.10.1 to 7.10.2 - [Release notes](https://github.com/mantinedev/mantine/releases) - [Changelog](https://github.com/mantinedev/mantine/blob/master/CHANGELOG.md) - [Commits](https://github.com/mantinedev/mantine/commits/7.10.2/packages/@mantine/dropzone) Updates `@mantine/form` from 7.10.1 to 7.10.2 - [Release notes](https://github.com/mantinedev/mantine/releases) - [Changelog](https://github.com/mantinedev/mantine/blob/master/CHANGELOG.md) - [Commits](https://github.com/mantinedev/mantine/commits/7.10.2/packages/@mantine/form) Updates `@mantine/hooks` from 7.10.1 to 7.10.2 - [Release notes](https://github.com/mantinedev/mantine/releases) - [Changelog](https://github.com/mantinedev/mantine/blob/master/CHANGELOG.md) - [Commits](https://github.com/mantinedev/mantine/commits/7.10.2/packages/@mantine/hooks) Updates `@mantine/modals` from 7.10.1 to 7.10.2 - [Release notes](https://github.com/mantinedev/mantine/releases) - [Changelog](https://github.com/mantinedev/mantine/blob/master/CHANGELOG.md) - [Commits](https://github.com/mantinedev/mantine/commits/7.10.2/packages/@mantine/modals) Updates `@mantine/notifications` from 7.10.1 to 7.10.2 - [Release notes](https://github.com/mantinedev/mantine/releases) - [Changelog](https://github.com/mantinedev/mantine/blob/master/CHANGELOG.md) - [Commits](https://github.com/mantinedev/mantine/commits/7.10.2/packages/@mantine/notifications) --- updated-dependencies: - dependency-name: "@mantine/core" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: mantine - dependency-name: "@mantine/dropzone" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: mantine - dependency-name: "@mantine/form" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: mantine - dependency-name: "@mantine/hooks" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: mantine - dependency-name: "@mantine/modals" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: mantine - dependency-name: "@mantine/notifications" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: mantine ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rver returned http 500.
const mediaType = subtitle.type; | ||
const mediaId = subtitle.id; | ||
const subtitlesPath = subtitle.path; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this is being removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are removing this, you gotta fix all its usages in the file.
I think there is a small issue with this PR, people have old settings saved on their file, what is going to happen if they don't come to update here? |
Implements a chips dialogue input on the Settings > Subtitles page that allows the user to input their choice of codecs to ignore during embedded sub detection. This is saved to a list as ignored_subs in general settings. Updates indexer logic for both series and movies to check this list during embedded sub check.