Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device id none #1767

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Device id none #1767

merged 3 commits into from
Nov 30, 2022

Conversation

dakinggg
Copy link
Contributor

What does this PR do?

Fixes a bad None check.

What issue(s) does this change relate to?

Fixes CO-1456

Before submitting

  • Have you read the contributor guidelines?
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@dakinggg dakinggg marked this pull request as ready for review November 30, 2022 01:13
mvpatel2000
mvpatel2000 approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F. LGTM

@dakinggg dakinggg merged commit 3405627 into mosaicml:dev Nov 30, 2022
@dakinggg dakinggg deleted the device_id_none branch November 30, 2022 22:06
bmosaicml pushed a commit to bmosaicml/composer that referenced this pull request Dec 13, 2022
@dakinggg @bmosaicml
Device id none (mosaicml#1767)
8635106 
Fixes a bad None check when setting device_id in DeviceGPU
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakinggg @mvpatel2000