-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove custom W&B config changes #236
Conversation
Removes custom 'algorithms' and 'models' sections from WB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but also remove the custom flattening in the next 60 or so lines
@siriuslee could you provide more motivation/context for this change, and how it impacts users of w&b? |
This removes some custom W&B work we did to make organizing our data collection efforts easier as the underlying composer library changed. A lot of these changes are now unnecessary or would be better made explicitly by the user. One of these changes (replacing model config data with the model name) actually deleted important configuration data. As for the flattening, W&B will partially flatten the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks just make sure checks pass
This was a hack I introduced during data collection to make Niklas’ data querying more consistent |
* Remove custom WB stuff Removes custom 'algorithms' and 'models' sections from WB * Fix * Add hparams flattening behind a flag * Fix overwriting extra_init_params when 'config' is provided * Fixed recursive error when `flatten_hparams` set to False
* Remove custom WB stuff Removes custom 'algorithms' and 'models' sections from WB * Fix * Add hparams flattening behind a flag * Fix overwriting extra_init_params when 'config' is provided * Fixed recursive error when `flatten_hparams` set to False
Removes custom 'algorithms' and 'models' sections from W&B