Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy imports for pycocotools #656

Merged
merged 3 commits into from
Mar 3, 2022
Merged

Lazy imports for pycocotools #656

merged 3 commits into from
Mar 3, 2022

Conversation

abhi-mosaic
Copy link
Member

@abhi-mosaic abhi-mosaic commented Mar 3, 2022

  1. This PR adds try..catch for the pycocotools imports, so that it's possible to use Composer locally without installing all the requirements. Right now with MCLI this was causing some issues.
  2. Remove the hack in the readthedocs build
  3. Fix the pycocotools in the meta.yaml to not install by default.
  4. Remove wget (this library hasn't been updated since 2015) as a dependency; replace with requests

@abhi-mosaic abhi-mosaic self-assigned this Mar 3, 2022
@ravi-mosaicml
Copy link
Contributor

I'm adding a few other fixes to this PR.

2. Fix the pycocotools in the meta.yaml
3. Add anaconda instructions for the conditional install
4. Remove wget as a dependency; repalce with requests
Copy link
Contributor

@ravi-mosaicml ravi-mosaicml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ravi-mosaicml ravi-mosaicml merged commit d715b60 into dev Mar 3, 2022
@ravi-mosaicml ravi-mosaicml deleted the abhi/lazy_coco branch March 3, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants