Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yahp version update to 0.1.0 #674

Merged
merged 5 commits into from
Mar 7, 2022
Merged

Yahp version update to 0.1.0 #674

merged 5 commits into from
Mar 7, 2022

Conversation

Averylamp
Copy link
Contributor

@Averylamp Averylamp commented Mar 4, 2022 •
edited
Loading

Bumps to >=0.1.0
Release notes here https://github.com/mosaicml/yahp/releases/tag/v0.1.0

@Averylamp Averylamp self-assigned this Mar 4, 2022
ravi-mosaicml
ravi-mosaicml approved these changes Mar 5, 2022
View reviewed changes
Copy link
Contributor

@ravi-mosaicml ravi-mosaicml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though let's use a type ignore for the type error right now...need to fix the underlying base class.

hanlint
hanlint approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@hanlint hanlint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanlint hanlint merged commit 6116263 into dev Mar 7, 2022
@hanlint hanlint deleted the avery/yahp-version-update branch March 7, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanlint hanlint hanlint approved these changes

@ravi-mosaicml ravi-mosaicml ravi-mosaicml approved these changes

Assignees

@Averylamp Averylamp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Averylamp @hanlint @ravi-mosaicml