Adding pyright to pre-commit #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanlint
reviewed
Aug 1, 2023
There was a problem hiding this comment.
Seriously, thank you for doing this. I only reviewed the llmfoundry folder files (stopped at pyproject.toml in this first pass). A few general notes:
- I saw
MutableMappingorMappingused forbatch. Is it possible to be consisent.. and is there a more narrow type, e.g.Dictthat could be used? - noted a few
assertthat maybe shoudl be informative user errors
dakinggg
changed the title
dakinggg
reviewed
Aug 1, 2023
Skylion007
approved these changes
Aug 2, 2023
vchiley
approved these changes
Aug 2, 2023
hanlint
reviewed
Aug 2, 2023
Co-authored-by: Vitaliy Chiley <6439018+vchiley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds pyright to precommit and gets it to pass so that we stop making things worse. Things that should still be done in the future include (1) getting rid of as many type ignores as possible and (2) adding return types to stuff (3) fix a todo with the model gauntlet callback which currently does not actually work as a callback.
I've also removed python 3.8 from the list of python versions. The
ast.unparsefunction used in the editing of the files for huggingface compatibility does not exist on python 3.8, and I think it is ok to require >=3.9