Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md - slack #273

Merged
merged 1 commit into from
May 24, 2023
Merged

Update README.md - slack #273

merged 1 commit into from
May 24, 2023

Conversation

ejyuen
Copy link
Contributor

@ejyuen ejyuen commented May 24, 2023

Updated Slack link to https://mosaicml.me/slack

We used a URL shortener so that if the Slack link dies on us we don't have to change all the slack links everywhere.

Please check if this works!

Description of changes:

Issue #, if available:

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

Updated Slack link to https://mosaicml.me/slack

We used a URL shortener so that if the Slack link dies on us we don't have to change all the slack links everywhere. 

Please check if this works!
Copy link
Collaborator

@karan6181 karan6181 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@karan6181 karan6181 mentioned this pull request May 24, 2023
@karan6181 karan6181 enabled auto-merge (squash) May 24, 2023 22:03
@karan6181 karan6181 merged commit 577408f into main May 24, 2023
@karan6181 karan6181 deleted the ejyuen-slack branch May 24, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants