Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LocalDataset (property size for fancy __getitem__). #305

Merged
merged 6 commits into from
Jun 16, 2023
Merged

Conversation

knighton
Copy link
Contributor

@knighton knighton commented Jun 16, 2023

Description of changes:

  • Fix LocalDataset (property size for fancy getitem).
  • Added a unit test for the same.

Issue #, if available:

#300

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

@knighton knighton requested a review from karan6181 June 16, 2023 20:33
@knighton knighton mentioned this pull request Jun 16, 2023
@knighton knighton merged commit 81d4ea7 into main Jun 16, 2023
@knighton knighton deleted the james/local branch June 16, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants