Fix Linting from Pillow version update #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orionw
pushed a commit
to orionw/streaming
that referenced
this pull request
Jul 10, 2024
XiaohanZhangCMU
added a commit
that referenced
this pull request
Jul 11, 2024
* init commit for hf * fix reqs * fix test * change error name; throw error; fix reqs * Update docs/source/how_to_guides/configure_cloud_storage_credentials.md Co-authored-by: Saaketh Narayan <saaketh@mosaicml.com> * fix test credential failure * cleanup * Remove duplicate `dbfs:` prefix from error message (#712) * fix typo in tests * docs * Try to figure out what is wrong with lint; test * fix os join * try to fix precommit * a (#713) * Upgrade ci_testing, remove codeql (#714) * linting_codeql * yo * yo * Wrap with nparray (#719) * Bump pydantic from 2.7.4 to 2.8.2 (#718) Bumps [pydantic](https://github.com/pydantic/pydantic) from 2.7.4 to 2.8.2. - [Release notes](https://github.com/pydantic/pydantic/releases) - [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md) - [Commits](pydantic/pydantic@v2.7.4...v2.8.2) --- updated-dependencies: - dependency-name: pydantic dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Xiaohan Zhang <xiaohanzhang.cmu@gmail.com> * Bump databricks-sdk from 0.28.0 to 0.29.0 (#715) Bumps [databricks-sdk](https://github.com/databricks/databricks-sdk-py) from 0.28.0 to 0.29.0. - [Release notes](https://github.com/databricks/databricks-sdk-py/releases) - [Changelog](https://github.com/databricks/databricks-sdk-py/blob/main/CHANGELOG.md) - [Commits](databricks/databricks-sdk-py@v0.28.0...v0.29.0) --- updated-dependencies: - dependency-name: databricks-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Xiaohan Zhang <xiaohanzhang.cmu@gmail.com> * update docstring * add isort --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Saaketh Narayan <saaketh@mosaicml.com> Co-authored-by: Vansh Singh <vansh.singh@databricks.com> Co-authored-by: bigning <bigning1118@gmail.com> Co-authored-by: Saaketh Narayan <saaketh.narayan@databricks.com> Co-authored-by: Xiaohan Zhang <xiaohanzhang.cmu@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Pillow version is bumped to 10.4.0 from 10.3.0, which results in the following Linting error
tests/test_encodings.py:206:31 - error: Argument of type "int" cannot be assigned to parameter "obj" of type "SupportsArrayInterface" in function "fromarray"
Reason is that fromarray expects np.array while np.random.randint returns Union[int, array]. Wrap with np.array fixes it.