Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #211 #212

Merged
merged 2 commits into from
Aug 7, 2018
Merged

Fix #211 #212

merged 2 commits into from
Aug 7, 2018

Conversation

mhverbakel
Copy link
Contributor

No description provided.

@mhverbakel
Copy link
Contributor Author

I don't think this failure is because of my changes. Could you restart the Travis CI?

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

id: that.id,
brokerId: that.broker.id
}, nop)
}
}
})
that.will = null // this function might be called twice
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huhm! authorizePublish is async function. Server will crash when that.broker.publish(that.will, that, done) called because that.will is null

@mhverbakel
Copy link
Contributor Author

mhverbakel commented Aug 13, 2018 via email

@nguyenthenguyen
Copy link
Contributor

@mhverbakel I have make a pull request #213

@nguyenthenguyen
Copy link
Contributor

@mhverbakel @mcollina Should we authorization will package when client connect?

@mhverbakel
Copy link
Contributor Author

I thought so too, but @mcollina thinks it should be on send (#211 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants