-
-
Notifications
You must be signed in to change notification settings - Fork 509
breaks due to node_redis 2.6.x #493
Comments
Same as the error shown in #490. Would you mind sending a PR that updates this to node-redis 2.6? |
@mcollina in reference to this (#493) and #490 Reverting the redis dependency to 2.5.3 seems to immediately resolve the issue at least from the test case perspective. There are 2 obvious options:
#2 is probably a bigger undertaking than it's worth given the ioredis upgrade mentioned in #1. My inclination would be to just focus on ioredis upgrade. The initial commit in #490 should still be integrated to resolve the HAProxy/redis stop/start problem. |
would you mind sending a PR pinning redis on 2.5.x?
|
Fixed in #494 |
I found that the way mosca uses Multi-Exec on node_redis 2.5.x may not work on 2.6.x.
For example, redis.js
The callback installed by get would only be called when an error occurs and effectively only takes 'err' as argument. subscriptions therefore remains undefined.
The following code can trigger the error:
Server output:
The text was updated successfully, but these errors were encountered: