Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Smarts strings for creation of secondary and tertiary alcohols #320

Merged
merged 6 commits into from
Mar 12, 2020

Conversation

Argon1999
Copy link
Contributor

@Argon1999 Argon1999 commented Feb 25, 2020

PR Summary:

Added Smarts strings for creation of secondary and tertiary alcohols.
Added test gro and top files for t-butanol and isopropanol.

PR Checklist


  • Includes appropriate unit test(s)
  • Appropriate docstring(s) are added/updated
  • Code is (approximately) PEP8 compliant
  • Issue(s) raised/addressed?

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #320 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #320   +/-   ##
=======================================
  Coverage   84.78%   84.78%           
=======================================
  Files          14       14           
  Lines        1275     1275           
=======================================
  Hits         1081     1081           
  Misses        194      194

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #320 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #320   +/-   ##
=======================================
  Coverage   84.78%   84.78%           
=======================================
  Files          14       14           
  Lines        1275     1275           
=======================================
  Hits         1081     1081           
  Misses        194      194           

Copy link
Member

@mattwthompson mattwthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny thing, otherwise LGTM

foyer/tests/implemented_opls_tests.txt Outdated Show resolved Hide resolved
@justinGilmer
Copy link
Contributor

Resolved the merge conflict. If all the tests pass, I am ready to merge.

@justinGilmer justinGilmer merged commit 72c0f07 into mosdef-hub:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants