Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes in gsd 3.0 #738

Closed
chrisjonesBSU opened this issue Jun 22, 2023 · 3 comments
Closed

Breaking changes in gsd 3.0 #738

chrisjonesBSU opened this issue Jun 22, 2023 · 3 comments
Assignees

Comments

@chrisjonesBSU
Copy link
Contributor

GSD 3.0 was recently released, and how some breaking changes in its API. It moves away from the Snapshot terminology and instead uses Frame

Example:

>>> import gsd.hoomd
>>> snap = gsd.hoomd.Snapshot
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'gsd.hoomd' has no attribute 'Snapshot'
>>> frame = gsd.hoomd.Frame
>>>

This causes some issues in convert_hoomd. I changed the version pinning for GSD in #737 as the tests were failing, but we'll still have to make some changes to support both gsd 2 and gsd 3.

@chrisjonesBSU chrisjonesBSU self-assigned this Jun 22, 2023
@chrisjonesBSU
Copy link
Contributor Author

I have a PR ready to go that adds some checks to io.py and convert_hoomd that supports both gsd 2.0 and 3.0.

I'm curious though what others think is the best way to proceed. gsd.hoomd.Frame is introduced in gsd 2.8 So, we could update convert_hoomd to use Frame and still technically support both major versions with gsd >= 2.8

@daico007
Copy link
Member

If they (gsd.hoomd.Frame and gsd.hoomd.Snapshot) is doing the same thing, my vote is to update all the syntax to work with gsd.hoomd.Frame and pin gsd to be >2.8

@CalCraven
Copy link
Contributor

I would second the adoption of gsd.hoomd.Frame, and pinning to >2.8.

This was referenced Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants