Support GSD 3 #739
Merged
Support GSD 3 #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
==========================================
- Coverage 91.99% 91.98% -0.02%
==========================================
Files 67 67
Lines 6459 6459
==========================================
- Hits 5942 5941 -1
- Misses 517 518 +1
☔ View full report in Codecov by Sentry. |
|
Linked to an issue that should fix the ubuntu tests that are failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few changes that supports using GSD 3.0 (#738 ). I pinned the version to
gsd>=2.9since the new API was introduced then.A couple of things to note:
Snapshotsnapshotin most of the variable names we use. If it makes more sense to update these names to use frame as well I can.