Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GSD >= 2.9 #1131

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Support GSD >= 2.9 #1131

merged 3 commits into from
Jun 27, 2023

Conversation

chrisjonesBSU
Copy link
Contributor

PR Summary:

Similar to mosdef-hub/gmso#739 this PR updates the gsd.hoomd class names used from Snapshot to Frame. The write modes are also updated.

Addresses #1130 if we decide to pin gsd to >= 2.9 which we talked about Here

PR Checklist


  • [x ] Includes appropriate unit test(s)
  • [ x] Appropriate docstring(s) are added/updated
  • [ x] Code is (approximately) PEP8 compliant
  • [ x] Issue(s) raised/addressed?

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.85 ⚠️

Comparison is base (d58e74e) 87.13% compared to head (18dfa2e) 85.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1131      +/-   ##
==========================================
- Coverage   87.13%   85.28%   -1.85%     
==========================================
  Files          62       62              
  Lines        6451     6451              
==========================================
- Hits         5621     5502     -119     
- Misses        830      949     +119     
Impacted Files Coverage Δ
mbuild/formats/hoomd_snapshot.py 76.14% <ø> (ø)
mbuild/__init__.py 100.00% <100.00%> (ø)
mbuild/formats/gsdwriter.py 95.89% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@daico007 daico007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daico007 daico007 merged commit 474b65f into mosdef-hub:main Jun 27, 2023
15 of 17 checks passed
@chrisjonesBSU chrisjonesBSU deleted the gsd3 branch June 27, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants