Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft for GMSO paper #797

Merged
merged 13 commits into from
Jan 24, 2024
Merged

First draft for GMSO paper #797

merged 13 commits into from
Jan 24, 2024

Conversation

daico007
Copy link
Member

@daico007 daico007 commented Jan 18, 2024

Adding the first draft of paper.md and paper.bib. Please feel free to review/add in any edit as you see fit. @CalCraven @chrisiacovella @mattwthompson @justinGilmer @umesh-timalsina @bc118 (feel free to tag more/the other authors, I just adding a few that I think is still active).

@daico007
Copy link
Member Author

We're planning to submit it to JOSS, submission instruction can be found here https://joss.readthedocs.io/en/latest/submitting.html#submission-requirements

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c7fbcd) 92.36% compared to head (48e3e1b) 92.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #797      +/-   ##
==========================================
- Coverage   92.36%   92.35%   -0.02%     
==========================================
  Files          66       66              
  Lines        6864     6864              
==========================================
- Hits         6340     6339       -1     
- Misses        524      525       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@chrisjonesBSU chrisjonesBSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting! I left a couple comments.

paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
@daico007
Copy link
Member Author

I think I merge this PR as the current state so it has a sharable link with all the PIs. Please feel free to continue review/editing the paper (you can either open a PR or send it to me).

@daico007 daico007 merged commit 85dc0d8 into mosdef-hub:main Jan 24, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants