Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.12 to CI workflow and environment files #822

Merged
merged 2 commits into from
May 23, 2024

Conversation

chrisjonesBSU
Copy link
Contributor

Now that mbuild 0.17.1 is released, I think we're ready to bump everything up to python 3.12 in GMSO.

@chrisjonesBSU chrisjonesBSU linked an issue May 21, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.10%. Comparing base (069170b) to head (6246895).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #822      +/-   ##
==========================================
+ Coverage   94.02%   94.10%   +0.08%     
==========================================
  Files          68       68              
  Lines        6859     6871      +12     
==========================================
+ Hits         6449     6466      +17     
+ Misses        410      405       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@daico007 daico007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daico007 daico007 merged commit 75747a8 into mosdef-hub:main May 23, 2024
20 checks passed
@chrisjonesBSU chrisjonesBSU deleted the py312 branch May 23, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add python 3.12 to tests and environment
2 participants