Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.12 to tests and environment #818

Closed
chrisjonesBSU opened this issue May 1, 2024 · 2 comments · Fixed by #822
Closed

Add python 3.12 to tests and environment #818

chrisjonesBSU opened this issue May 1, 2024 · 2 comments · Fixed by #822

Comments

@chrisjonesBSU
Copy link
Contributor

Once mosdef-hub/mbuild#1180 passes I think we should do the same here; adding python 3.12 to the CI workflow, updating the .yml files to include python 3.12 and make sure the feedstock for the next release includes 3.12 as well.

Also in the PR linked, I mention how macOS-latest is now an ARM based image of Mac, so if we want to test both ARM and intel we'll have to add macOS-13 to the os-matrix, we should probably do that here as well.

@chrisjonesBSU
Copy link
Contributor Author

Before we can do this, we might have to make a new release of mBuild. If we try to install mbuild from anaconda with python pinned at 3.12 we'll get mbuild 0.16.4 which won't work with python 3.12.

@chrisjonesBSU
Copy link
Contributor Author

Another thing to remember for this is the changes to the MacOS images used in the CI workflow. If we want to test MacOS x86 we need to add macos-13 to the os-matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant