Fix hoomd version handling in convert_hoomd.py
#828
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed a bug that you will get
hoomd not defined
error when importing anything fromgmso.external
(evenfrom_mbuild
andto_mbuild
) and don't have hoomd in your environment.This is happening because the hoomd import in
convert_hoomd
is under an if statement, but a few lines later we callhoomd.version
@CalCraven @daico007 should we do a quick patch release to get this fix in the conda package asap?