Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hoomd version handling in convert_hoomd.py #828

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

chrisjonesBSU
Copy link
Contributor

I've noticed a bug that you will get hoomd not defined error when importing anything from gmso.external (even from_mbuild and to_mbuild) and don't have hoomd in your environment.

This is happening because the hoomd import in convert_hoomd is under an if statement, but a few lines later we call hoomd.version

@CalCraven @daico007 should we do a quick patch release to get this fix in the conda package asap?

@chrisjonesBSU chrisjonesBSU added the bug Something isn't working label Jun 21, 2024
@daico007
Copy link
Member

Yeah, I think this warrants a patch release

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.04%. Comparing base (5b3040a) to head (855f07a).
Report is 60 commits behind head on main.

Files with missing lines Patch % Lines
gmso/external/convert_hoomd.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
- Coverage   94.09%   94.04%   -0.05%     
==========================================
  Files          65       65              
  Lines        6870     6953      +83     
==========================================
+ Hits         6464     6539      +75     
- Misses        406      414       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@CalCraven CalCraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea let’s release merge this and then this weekend do another patch release.

@CalCraven CalCraven merged commit 6b18346 into mosdef-hub:main Jun 21, 2024
18 of 20 checks passed
@chrisjonesBSU chrisjonesBSU deleted the fix-hoomd-import branch June 21, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants