Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing for py3.10 and 3.11 #1110

Merged
merged 5 commits into from
May 12, 2023
Merged

Conversation

daico007
Copy link
Member

@daico007 daico007 commented May 3, 2023

PR Summary:

I think it's time we need to add support/test for python 3.10 and 3.11.

PR Checklist


  • Includes appropriate unit test(s)
  • Appropriate docstring(s) are added/updated
  • Code is (approximately) PEP8 compliant
  • Issue(s) raised/addressed?

@daico007 daico007 marked this pull request as ready for review May 3, 2023 17:43
@daico007
Copy link
Member Author

daico007 commented May 3, 2023

Depends on how py3.11 do, we may want to drop testing for python 3.8

@daico007
Copy link
Member Author

daico007 commented May 3, 2023

I don't think I can add the 3.10 and 3.11 requirement until this PR is merged. So I may have to merge this first fix things in a follow up PR.

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -2.62 ⚠️

Comparison is base (e79447b) 89.51% compared to head (1a47e5c) 86.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1110      +/-   ##
==========================================
- Coverage   89.51%   86.89%   -2.62%     
==========================================
  Files          61       61              
  Lines        6311     6317       +6     
==========================================
- Hits         5649     5489     -160     
- Misses        662      828     +166     
Impacted Files Coverage Δ
mbuild/lib/recipes/alkane.py 40.00% <66.66%> (+1.11%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daico007
Copy link
Member Author

daico007 commented May 5, 2023

Ok, turn out hoomd 2.9 is not compatible with python>3.9, so we probably may have to drop it moving forward (and replace with hoomd 3).

This was referenced May 9, 2023
@daico007 daico007 merged commit 2b1f5de into mosdef-hub:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant