Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings for deprecated file formats (protobuf, hoomdxml, Hoomd-Blue and LAMMPS simulation writers) #1188

Merged
merged 8 commits into from
Jun 17, 2024

Conversation

chrisjonesBSU
Copy link
Contributor

PR Summary:

Per the last few dev meetings, we've been discussing what needs to be done before releasing 1.0. We decided to clean up and consolidate conversion.py which involves moving the backend to GMSO wherever possible, and removing .hoomdxml and .pb2 readers and writers. Also, we decided to remove any mbuild.format writers that are now duplicated in GMSO such as create_hoomd_simulation, create_hoomd_forcefield, and write_lammpsdata.

We decided that the first step was including the necessary deprecation warnings in a minor release, which this PR gets started. I think this covers everything that will be removed from mBuild, and any other changes to readers and writers will just involve changing the backend and won't require a deprecation warning. Let me know if I'm missing anything, or if we need to expand in the warning messages.

I can start making the next round of changes in a separate PR.

mbuild/formats/hoomd_forcefield.py Outdated Show resolved Hide resolved
mbuild/formats/hoomd_simulation.py Outdated Show resolved Hide resolved
mbuild/formats/lammpsdata.py Outdated Show resolved Hide resolved
mbuild/formats/hoomd_forcefield.py Show resolved Hide resolved
mbuild/formats/hoomd_simulation.py Outdated Show resolved Hide resolved
@CalCraven
Copy link
Contributor

Ran this locally to test the failing tests, which are all related to packmol. They pass with versions:
packmol 20.010 h508aa58_0 conda-forge

For the CI, looks like we're installing
packmol[version='>=20'], and get
packmol 20.14.4 h4c1867c_0 conda-forge

So that may be the source of the issues, external to the PR.

@CalCraven
Copy link
Contributor

Here's the error file in the log that packmol spits out.

STOP: Maximum number of GENCAN loops achieved.

--------------------------------------------------------------------------------

 Packmol was not able to find a solution to your
 packing problem with the desired distance tolerance.

 First of all, be sure if the molecules fit in the
 regions specified and if the constraints were set
 correctly. 

 Secondly, try simply running it again with a different 
 seed for the random number generator of the initial 
 point. This is done by adding the keyword seed to the
 input file, as in: 

mbuild/formats/hoomd_forcefield.py Outdated Show resolved Hide resolved
@chrisjonesBSU
Copy link
Contributor Author

The messages were updated with the full path to the relevant GMSO writers.

@daico007 daico007 merged commit cd53189 into mosdef-hub:main Jun 17, 2024
19 checks passed
@chrisjonesBSU chrisjonesBSU deleted the deprecation-warnings branch June 17, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants