refactor rust part #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemingy
commented
Sep 5, 2021
| data | ||
| } | ||
|
|
||
| pub(crate) fn update_multi_tasks(&self, code: TaskCode, ids: &[u32], data: &[Bytes]) { |
There was a problem hiding this comment.
This function should be able to remove the timeout ids to increase the efficiency. Not sure if it's necessary to do here.
| let mut data: Vec<Bytes> = Vec::with_capacity(ids.len()); | ||
| let table = self.table.read(); | ||
| // delete the task_id if the task_id doesn't exist in the table | ||
| ids.retain(|&id| match table.get(&id) { |
There was a problem hiding this comment.
Not sure if retain can get a slight better performance.
lkevinzc
reviewed
Sep 5, 2021
lkevinzc
reviewed
Sep 5, 2021
lkevinzc
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #26
close #20
close #21
close #22