Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented thread safety #15

Merged
merged 4 commits into from Jan 9, 2020
Merged

Implemented thread safety #15

merged 4 commits into from Jan 9, 2020

Conversation

moshiba
Copy link
Owner

@moshiba moshiba commented Jan 9, 2020

No description provided.

@moshiba moshiba added the enhancement New feature or request label Jan 9, 2020
@todo
Copy link

todo bot commented Jan 9, 2020

find better dynamic min_interval_iter adjustments, might

https://github.com/HsuanTingLu/pbar/blob/b484f153c23adb378dbbbdbf04cffdffce3fbfe3/pbar/pbar.cpp#L210-L215

This comment was generated by todo based on a TODO comment in b484f15 in #15. cc @HsuanTingLu.

@todo
Copy link

todo bot commented Jan 9, 2020

implement internal set instead of simple counting to maintain

https://github.com/HsuanTingLu/pbar/blob/b484f153c23adb378dbbbdbf04cffdffce3fbfe3/pbar/pbar.cpp#L242-L247

This comment was generated by todo based on a TODO comment in b484f15 in #15. cc @HsuanTingLu.

@todo
Copy link

todo bot commented Jan 9, 2020

write final stats

https://github.com/HsuanTingLu/pbar/blob/b484f153c23adb378dbbbdbf04cffdffce3fbfe3/pbar/pbar.cpp#L247-L252

This comment was generated by todo based on a TODO comment in b484f15 in #15. cc @HsuanTingLu.

@todo
Copy link

todo bot commented Jan 9, 2020

Not copyable, but movable

https://github.com/HsuanTingLu/pbar/blob/b484f153c23adb378dbbbdbf04cffdffce3fbfe3/pbar/pbar.hpp#L54-L59

This comment was generated by todo based on a TODO comment in b484f15 in #15. cc @HsuanTingLu.

@moshiba moshiba merged commit 8aef5d1 into master Jan 9, 2020
This was referenced Jan 9, 2020
Open
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@moshiba