-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes vendoring and updates to Go 1.18 #50
Conversation
ps for vendoring, I simply ran |
we can delete the vendor directory to ignore it, and do not modify the version of protobuf that depended on by istio. |
ok good advice. I'll remove vendoring and switch the protobuf version back to the older patch. I'll add a note in go.mod that this must match Istio. |
@taoyuanyuan on protobuf and Istio... I can't find an istio version that uses v1.5.0. Do you still want me to lock that version, or should we go with 1.5.2 instead? istio 1.10.0 was released last may and uses protobuf v1.5.1 https://github.com/istio/istio/blob/1.10.0/go.mod
istio 1.11.0 was released last august with protobuf v1.5.2 and this is still in use in latest istio I'd like to document something about istio, but I want to make sure it is relevant. Advice? |
https://github.com/envoyproxy/go-control-plane/blob/v0.10.0/go.mod |
thanks I'll make the appropriate comment as it will help the next person. Cheers! |
This updates to Go 1.18 and removes the vendor directory. Per Go's release policy, Go 1.14 has been unsupported for a while. This also adds CI so that we know the project can be built. Signed-off-by: Adrian Cole <adrian@tetrate.io>
e85d861
to
7dd87ed
Compare
ok @taoyuanyuan PTAL! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This updates to Go 1.18 and removes the vendor directory.
Per Go's release policy, Go 1.14 has been unsupported for a while.
This also adds CI so that we know the project can be built.
see mosn/mosn#2145 (comment)
see https://go.dev/doc/devel/release#policy