Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes vendoring and updates to Go 1.18 #50

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

codefromthecrypt
Copy link
Contributor

@codefromthecrypt codefromthecrypt commented Oct 19, 2022

This updates to Go 1.18 and removes the vendor directory.

Per Go's release policy, Go 1.14 has been unsupported for a while.

This also adds CI so that we know the project can be built.

see mosn/mosn#2145 (comment)
see https://go.dev/doc/devel/release#policy

@codefromthecrypt
Copy link
Contributor Author

ps for vendoring, I simply ran go mod vendor which did all the modules, not just rcrowley. If you have other commands or want to push a commit to do something different, please do so. Just check that go build ./... works afterwards, or also change CI to whatever command is expected.

@taoyuanyuan
Copy link
Contributor

we can delete the vendor directory to ignore it, and do not modify the version of protobuf that depended on by istio.

@codefromthecrypt
Copy link
Contributor Author

ok good advice. I'll remove vendoring and switch the protobuf version back to the older patch. I'll add a note in go.mod that this must match Istio.

@codefromthecrypt
Copy link
Contributor Author

codefromthecrypt commented Oct 20, 2022

@taoyuanyuan on protobuf and Istio... I can't find an istio version that uses v1.5.0. Do you still want me to lock that version, or should we go with 1.5.2 instead?

istio 1.10.0 was released last may and uses protobuf v1.5.1 https://github.com/istio/istio/blob/1.10.0/go.mod

  • before that, istio used protobuf v1.4.3 not v1.5.0

istio 1.11.0 was released last august with protobuf v1.5.2 and this is still in use in latest istio

I'd like to document something about istio, but I want to make sure it is relevant. Advice?

@taoyuanyuan
Copy link
Contributor

https://github.com/envoyproxy/go-control-plane/blob/v0.10.0/go.mod
https://github.com/mosn/mosn/blob/0e489a0c809b7e1bbb041d4682e8da045613dd6e/go.mod#L67
oh, I'm sorry, I see MOSN uses go-control-plane v0.10.0 depended protobuf 1.5.0, but not istio.
We can make minimal changes and do not modify this version.

@codefromthecrypt
Copy link
Contributor Author

thanks I'll make the appropriate comment as it will help the next person. Cheers!

This updates to Go 1.18 and removes the vendor directory.

Per Go's release policy, Go 1.14 has been unsupported for a while.

This also adds CI so that we know the project can be built.

Signed-off-by: Adrian Cole <adrian@tetrate.io>
@codefromthecrypt codefromthecrypt changed the title Updates dependencies, notably go to 1.18 and adds CI Removes vendoring and updates to Go 1.18 Oct 20, 2022
@codefromthecrypt
Copy link
Contributor Author

ok @taoyuanyuan PTAL!

Copy link
Contributor

@taoyuanyuan taoyuanyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants