Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes vendoring and updates to Go 1.18 and latest fasthttp #65

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

codefromthecrypt
Copy link
Contributor

@codefromthecrypt codefromthecrypt commented Oct 20, 2022

This updates to Go 1.18 and removes the vendor directory.

Per Go's release policy, Go 1.14 has been unsupported for a while.

This also updates to latest fasthttp so that mosn can support HTTP trailers.

see mosn/api#50
see mosn/mosn#2145 (comment)
see https://go.dev/doc/devel/release#policy

cc @taoyuanyuan

This updates to Go 1.18 and removes the vendor directory.

Per Go's release policy, Go 1.14 has been unsupported for a while.

This also updates to latest fasthttp so that mosn can support HTTP
trailers.

Signed-off-by: Adrian Cole <adrian@tetrate.io>
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2022

Codecov Report

Base: 45.73% // Head: 49.44% // Increases project coverage by +3.71% 🎉

Coverage data is based on head (4f68706) compared to base (949046a).
Patch coverage: 79.86% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   45.73%   49.44%   +3.71%     
==========================================
  Files          48       56       +8     
  Lines        2683     2985     +302     
==========================================
+ Hits         1227     1476     +249     
- Misses       1374     1410      +36     
- Partials       82       99      +17     
Impacted Files Coverage Δ
variable/protocolres.go 61.90% <61.90%> (ø)
variable/api.go 69.76% <69.76%> (ø)
variable/factory.go 73.17% <73.17%> (ø)
buffer/buffer.go 80.28% <80.28%> (ø)
variable/var.go 96.15% <96.15%> (ø)
buffer/bytebuffer_ctx.go 100.00% <100.00%> (ø)
buffer/log.go 50.00% <100.00%> (ø)
internal/context/context.go 100.00% <100.00%> (ø)
internal/context/wrapper.go 100.00% <100.00%> (ø)
log/logger.go 50.83% <0.00%> (-1.25%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Adrian Cole <adrian@tetrate.io>
@codefromthecrypt
Copy link
Contributor Author

@taoyuanyuan can you re-kick CI, I tried with a newer version of the same lint job.

Copy link
Contributor

@taoyuanyuan taoyuanyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants