Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #89 #92

Merged
merged 1 commit into from
Mar 31, 2022
Merged

fix: #89 #92

merged 1 commit into from
Mar 31, 2022

Conversation

songzhibin97
Copy link
Member

No description provided.

@mosn-community-bot mosn-community-bot bot added bug Something isn't working cla:yes size/S labels Mar 30, 2022
@doujiang24
Copy link
Member

better add a test case for it, otherwise, LGTM.

@songzhibin97
Copy link
Member Author

LGTM

@doujiang24 doujiang24 requested a review from Jun10ng March 31, 2022 10:48
@doujiang24 doujiang24 merged commit 5ef1645 into mosn:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doujiang24 doujiang24 doujiang24 approved these changes

@Jun10ng Jun10ng Awaiting requested review from Jun10ng

Assignees
No one assigned
Labels
bug Something isn't working cla:yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@songzhibin97 @doujiang24